Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

update always_specify_types to lint generic methods #1144

Closed

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Aug 29, 2018

@a14n a14n force-pushed the always_specify_types-generic-methods branch from e7ec005 to 0433b13 Compare August 29, 2018 20:32
@bwilkerson
Copy link
Contributor

I'm concerned about the number of false positives. You're correct that the SDK cannot reference anything outside the SDK, making it impossible (currently) to mark generic methods in the SDK as having optional type parameters.

One possibility is to split this rule into three parts:

  • requiring type annotations (like for variables, etc.),
  • requiring type arguments for classes, and
  • requiring type arguments for methods.

That would at least keep a change like this from breaking existing users of the lint who don't want to go quite as far as to add type arguments to all method invocations.

@a14n
Copy link
Contributor Author

a14n commented Aug 31, 2018

One possibility is to split this rule into three parts

+1

@a14n
Copy link
Contributor Author

a14n commented Sep 4, 2018

Split done in #1153

@a14n
Copy link
Contributor Author

a14n commented Sep 21, 2018

As of #1153 (comment) I will re-open this one and maintain the 2 branchs

@a14n
Copy link
Contributor Author

a14n commented Sep 21, 2018

hmm, I can't reopen :-/ I created #1178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants