This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Fix cascade_invocations false positive when examining complicated expressions #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/rules/cascade_invocations.dart
Outdated
| int f; | ||
| int g; | ||
|
|
||
| void x() {} |
There was a problem hiding this comment.
You don't seem to be using these methods. If so, remove them.
alexeieleusis
approved these changes
Dec 27, 2018
|
Thanks for the PR, quite a contrived use case! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#57855
The lint rule uses
getCanonicalElementFromIdentifierto see if two statements act on the same element, in order to report that they can be combined with a cascade. But unless the expressions are simple, up to a point, the rule cannot know that one statement acts onb1.aand the second acts onb2.a, even though both act onA get a.