Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

allow overriding abstract fields in NNBD #2285

Merged
merged 2 commits into from
Oct 12, 2020
Merged

allow overriding abstract fields in NNBD #2285

merged 2 commits into from
Oct 12, 2020

Conversation

pq
Copy link
Contributor

@pq pq commented Oct 12, 2020

@google-cla google-cla bot added the cla: yes label Oct 12, 2020
@coveralls
Copy link

coveralls commented Oct 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0005%) to 96.57% when pulling b34eab3 on abstract_nnbd_overrides into b2b99eb on master.

a14n
a14n approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@a14n a14n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwilkerson
bwilkerson approved these changes Oct 12, 2020
View reviewed changes
test/rules/experiments/nnbd/rules/overridden_fields.dart
@@ -0,0 +1,181 @@
// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: year

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been preserving the years for copies of existing tests. Happy to rethink though?

@pq pq merged commit d2ac0a6 into master Oct 12, 2020
@pq pq deleted the abstract_nnbd_overrides branch October 12, 2020 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a14n a14n a14n approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overridden_fields should not report if the parent field is abstract
4 participants
@pq @coveralls @a14n @bwilkerson