This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Fix false negative in prefer_contains
#2830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
added
linter-false-negative
linter-set-recommended
bwilkerson
reviewed
Jul 29, 2021
bwilkerson
approved these changes
Jul 29, 2021
|
I'd love to test this internally, @asashour , if you want to rebase. |
# Conflicts: # lib/src/util/dart_type_utilities.dart
github-actions
bot
removed
the
linter-set-recommended
|
Conflict was merged. Please note there is an issue with Dart 3. |
bwilkerson
reviewed
Dec 9, 2022
|
All good internally. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
* Fix false negative in `prefer_contains` * restrict for TypeParameterType * use `typeForInterfaceCheck` * Rename to `typeToCheck`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the
prefer_containspart of dart-lang/sdk#58406Please note the change is in
DartTypeUtilities, which would potentially affect other rules as well.