Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/src/rules/void_checks.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,10 @@ class VoidChecks extends LintRule {
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
var visitor = _Visitor(this, context);
registry.addMethodInvocation(this, visitor);
registry.addInstanceCreationExpression(this, visitor);
registry.addAssignedVariablePattern(this, visitor);
registry.addAssignmentExpression(this, visitor);
registry.addInstanceCreationExpression(this, visitor);
registry.addMethodInvocation(this, visitor);
registry.addReturnStatement(this, visitor);
}
}
Expand Down Expand Up @@ -89,6 +90,14 @@ class _Visitor extends SimpleAstVisitor<void> {
return false;
}

@override
void visitAssignedVariablePattern(AssignedVariablePattern node) {
var valueType = node.matchedValueType;
var element = node.element;
if (element is! VariableElement) return;
_check(element.type, valueType, node);
}

@override
void visitAssignmentExpression(AssignmentExpression node) {
var type = node.writeType;
Expand Down
40 changes: 40 additions & 0 deletions test/rules/void_checks_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import '../rule_test_support.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(VoidChecksTest);
defineReflectiveTests(VoidChecksTestLanguage300);
});
}

Expand Down Expand Up @@ -52,3 +53,42 @@ void bug2813() {
]);
}
}

@reflectiveTest
class VoidChecksTestLanguage300 extends LintRuleTest
with LanguageVersion300Mixin {
@override
String get lintRule => 'void_checks';

test_listPattern_local() async {
await assertDiagnostics(r'''
void f() {
void p;
[p] = <int>[7];
return p;
}
''', [
lint(24, 1),
]);
}

test_listPattern_param() async {
await assertDiagnostics(r'''
void f(void p) {
[p] = <int>[7];
}
''', [
lint(20, 1),
]);
}

test_recordPattern() async {
await assertDiagnostics(r'''
void f(void p) {
(p, ) = (7, );
}
''', [
lint(20, 1),
]);
}
}