Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

extension type support for library_private_types_in_public_api #4660

Merged
merged 2 commits into from
Aug 10, 2023
Merged

extension type support for library_private_types_in_public_api #4660

merged 2 commits into from
Aug 10, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Aug 10, 2023

@github-actions github-actions bot added the linter-set-recommended Affects a rule in the recommended Dart rule set label Aug 10, 2023
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 96.532% (+0.003%) from 96.529% when pulling e5a1523 on library_private_types_in_public_api_extensionTypes into 7e235be on main.

bwilkerson
bwilkerson approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one change made (assuming I'm right about the semantics).

@pq pq merged commit 2eb1140 into main Aug 10, 2023
@pq pq deleted the library_private_types_in_public_api_extensionTypes branch August 10, 2023 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
linter-set-recommended Affects a rule in the recommended Dart rule set
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

library_private_types_in_public_api support for extension types
3 participants
@pq @coveralls @bwilkerson