-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
README.md
Outdated
## How these lints are used | ||
|
||
When creating new Dart project using the [`dart create`][dart create] command, | ||
the 'recommended' set of lints are enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @devoncarew; I think the template currently is using core? (https://dart-review.googlesource.com/c/sdk/+/198620)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to core or update the template?
/cc @devoncarew @mit-mit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - this is not in sync w/ what dart create
does. I believe that it was decided to use core
- what pub scores with - but was not in that particular conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote is for updating dart create
to push people towards the recommended set. There are a lot of good lints in there. It would also align a little closer with flutter since flutter_lints
builds on top of recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep that as a separete issue; no need to block this readme update on that. I've made the text here more general.
I'll share a doc with some analysis for making the choice regarding dart create
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking issue: https://github.com/dart-lang/lints/issues/20
In this readme, we should also include the fact that you need to add a dev. dependency on lints to your pubspec (w/ a small sample snippet) and a sample of a simple analysis_options file. Perhaps in a 'how to use' section?
|
Good idea; added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo reconciling the the item that Phil found; we should update this readme or the behavior of dart create.
README.md
Outdated
## How these lints are used | ||
|
||
When creating new Dart project using the [`dart create`][dart create] command, | ||
the 'recommended' set of lints are enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - this is not in sync w/ what dart create
does. I believe that it was decided to use core
- what pub scores with - but was not in that particular conversation.
Fixes dart-lang/core#841