Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Update README.md #18

Merged
merged 5 commits into from
May 11, 2021
Merged

Update README.md #18

merged 5 commits into from
May 11, 2021

Conversation

mit-mit
Copy link
Contributor

@mit-mit mit-mit commented May 11, 2021

README.md Outdated
## How these lints are used

When creating new Dart project using the [`dart create`][dart create] command,
the 'recommended' set of lints are enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @devoncarew; I think the template currently is using core? (https://dart-review.googlesource.com/c/sdk/+/198620)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to core or update the template?

/cc @devoncarew @mit-mit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - this is not in sync w/ what dart create does. I believe that it was decided to use core - what pub scores with - but was not in that particular conversation.

Copy link
Contributor

@goderbauer goderbauer May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote is for updating dart create to push people towards the recommended set. There are a lot of good lints in there. It would also align a little closer with flutter since flutter_lints builds on top of recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that as a separete issue; no need to block this readme update on that. I've made the text here more general.

I'll share a doc with some analysis for making the choice regarding dart create.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devoncarew
Copy link
Contributor

devoncarew commented May 11, 2021

In this readme, we should also include the fact that you need to add a dev. dependency on lints to your pubspec (w/ a small sample snippet) and a sample of a simple analysis_options file. Perhaps in a 'how to use' section?

## How to use

Add a dev dependency on this package to your `pubspec.yaml` file:

``yaml
dev_dependencies:
  lints: ^1.0.0
``

And create a new `analysis_options.yaml` file, next to the pubspec, that includes the lints package:

``yaml
include: package:lints/core.yaml
``

@mit-mit
Copy link
Contributor Author

mit-mit commented May 11, 2021

In this readme, we should also include the fact that you need to add a dev. dependency on lints to your pubspec (w/ a small sample snippet) and a sample of a simple analysis_options file. Perhaps in a 'how to use' section?

Good idea; added

Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo reconciling the the item that Phil found; we should update this readme or the behavior of dart create.

README.md Outdated
## How these lints are used

When creating new Dart project using the [`dart create`][dart create] command,
the 'recommended' set of lints are enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - this is not in sync w/ what dart create does. I believe that it was decided to use core - what pub scores with - but was not in that particular conversation.

@mit-mit mit-mit merged commit 75244f5 into main May 11, 2021
@mit-mit mit-mit deleted the mit-mit-patch-1 branch May 11, 2021 20:06
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add more documentation to the readme
4 participants