This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Add method returning all sub-routes of a Route object #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/client.dart
Outdated
|
You are right. Hope that fits. |
test/client_test.dart
Outdated
|
Also add the method to RouteHandle https://github.com/angular/route.dart/blob/master/lib/route_handle.dart |
|
Would you like to have RouteHandle return its route's subRoutes or throw "unsupported"? |
|
It should return _route.subRoutes |
raptaml
changed the title
|
Hi, will this be released? And if so, when is ETA ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An easy way to get all sub-routes of a Route was missing.
This PR adds it to abstract class Route and its implementation.
Tests pass in current content-shell full-stable-45692.0.