Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Add helpers to make it easier to do stuff in the sandbox #13

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Add helpers to make it easier to do stuff in the sandbox #13

merged 3 commits into from
Jun 18, 2018

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 14, 2018

No description provided.

@nex3 nex3 requested a review from munificent June 14, 2018 22:30
munificent
munificent approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for path() too and then LGTM.

Do you want to prevent the user from passing in a relative path that walks back out of the sandbox?

@nex3
Copy link
Contributor Author

nex3 commented Jun 18, 2018

Add a test for path() too and then LGTM.

Done.

Do you want to prevent the user from passing in a relative path that walks back out of the sandbox?

Eh, that seems like a pretty narrow edge case with high risk for bogus errors.

@nex3 nex3 merged commit 3470bcc into master Jun 18, 2018
@nex3 nex3 deleted the helpers branch June 18, 2018 23:50
mosuem pushed a commit to dart-lang/test that referenced this pull request Dec 12, 2024
@nex3
Add helpers to make it easier to do stuff in the sandbox (dart-archiv…
d9a6cac 
…e/test_descriptor#13)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@munificent munificent munificent approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @munificent