This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Update try/catch syntax #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream
Update upstream
update simple example to include required 'name' parameter.
Conflicts: src/site/docs/pub-package-manager/index.markdown
|
Awesome, thanks Matt! BTW you might want to use a rebase workflow. It will squash your commits into one, making it a bit easier to review. |
|
LGTM! |
|
Sorry about that. It was also in part due to my inexperience with git and trying to properly merge your previous commit with my fork. I'll look into a rebase workflow to help keep things cleaner. |
|
yeah... personally I avoid the rebase workflow because it's more likely to cause merge conflicts (strange stuff like conflicting with yourself, resolving conflicts multiple times during the rebase process). But my experience is with git-svn so YMMV. Rebase does create nicer looking commit logs. |
alanjoyce
pushed a commit
to alanjoyce/dartlang.org
that referenced
this pull request
Nov 7, 2013
a few cleanup fixes (article cleanup, navbar fix, font import)
This was referenced Aug 26, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to use the new 'on' syntax and drop 'final'