This repository was archived by the owner on Feb 22, 2018. It is now read-only.
add missing src/ directory to implementation files example #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but note that the example import below that also shouldn't say 'lib/', which is implicitly added by pub. |
lib directory is implicit for packages even when importing from src/
|
I didn't realize that, but makes sense now that you mention it (since it's implicit for other imports). Updated that as well. |
|
lgtm, thanks! |
|
@sethladd or @munificent able to accept pull request? |
sethladd
added a commit
that referenced
this pull request
Sep 13, 2012
add missing src/ directory to implementation files example
alanjoyce
pushed a commit
to alanjoyce/dartlang.org
that referenced
this pull request
Nov 8, 2013
Template improvements, including a complete rework of /tools/editor
This was referenced Jun 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import statement (and full example layout at top of page) show beans.dart and queso.dart in lib/src/ not just lib/