Skip to content

Conversation

tomarra
Copy link
Contributor

@tomarra tomarra commented Aug 27, 2024

Status

READY

Description

Fixes #1481

Attempting to fix the issue with multiple Dart Frog logos showing up on Pub.dev. Just getting it to one logo for now without wording.

CleanShot 2024-08-27 at 10 20 16

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@tomarra tomarra requested a review from a team as a code owner August 27, 2024 15:20
@tomarra tomarra changed the title Update README.md docs: update Dart Frog CLI logo in Readme Aug 27, 2024
@tomarra tomarra closed this Aug 27, 2024
@tomarra tomarra reopened this Aug 27, 2024
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the logo without the text, otherwise the contrast in dark themes makes it elegible.

CleanShot 2024-08-27 at 16 31 06@2x

@tomarra
Copy link
Contributor Author

tomarra commented Aug 27, 2024

@alestiago updated to use the PNG we already have. It's slightly bigger image dimension wise but I think good enough.

@tomarra tomarra requested a review from alestiago August 27, 2024 15:34
@tomarra tomarra requested a review from alestiago August 27, 2024 15:48
@alestiago
Copy link
Contributor

I think we might have to readjust the size of the logo to get it a bit more aligned like the Very Good CLI one, wdyt?

CleanShot 2024-08-27 at 17 25 21@2x

alestiago
alestiago previously approved these changes Aug 28, 2024
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Can we also get the change in the other Dart Frog packages (can be as a separate PR)?

@tomarra
Copy link
Contributor Author

tomarra commented Aug 28, 2024

Looks awesome! Can we also get the change in the other Dart Frog packages (can be as a separate PR)?

Ah that's a good call. I think I can do it quickly here.

@tomarra tomarra requested a review from alestiago August 28, 2024 14:08
@tomarra tomarra changed the title docs: update Dart Frog CLI logo in Readme docs: update Dart Frog's logo in Readme files Aug 28, 2024
@tomarra tomarra merged commit 114bb76 into main Aug 28, 2024
3 checks passed
@tomarra tomarra deleted the cli-readme-logoupdate branch August 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Fix Double Logo on Pub.dev

2 participants