Skip to content

Conversation

nielsenko
Copy link

Setup Dart 3.6 workspace


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

publish_to: "none"
version: 0.1.0-wip

resolution: workspace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one probably shouldn't be a part of the workspace because it has flutter DEPS - I believe it would ultimately require using the flutter SDK to develop all packages in this repo, when most of them only require the Dart SDK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the counter_app project from the workspace. I left comments behind. Say, if you prefer just to remove it?

@nielsenko nielsenko marked this pull request as ready for review September 11, 2025 09:32
Copy link

PR Health

Changelog Entry
Package Changed Files
package:dart_mcp pkgs/dart_mcp/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

resolution: workspace
environment:
sdk: ^3.7.0
sdk: ^3.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik we don't need to update the SDK constraint for this, you only need 3.6.0. It is better to keep this version lower to increase compatibility.

Suggested change
sdk: ^3.9.0
sdk: ^3.7.0

Same for the other packages please :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped commit: 4fb3fc8 chore: Bump sdk to ^3.9.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the workspace won't resolve unless you are on sdk ^3.9.0-163.0.dev, since that is the current lower bound in pkgs/dart_mcp_server/pubspec.yaml.

@nielsenko nielsenko marked this pull request as draft September 15, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants