-
Notifications
You must be signed in to change notification settings - Fork 40
build: Add workspace #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build: Add workspace #281
Conversation
publish_to: "none" | ||
version: 0.1.0-wip | ||
|
||
resolution: workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one probably shouldn't be a part of the workspace because it has flutter DEPS - I believe it would ultimately require using the flutter SDK to develop all packages in this repo, when most of them only require the Dart SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the counter_app project from the workspace. I left comments behind. Say, if you prefer just to remove it?
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
pkgs/dart_mcp/pubspec.yaml
Outdated
resolution: workspace | ||
environment: | ||
sdk: ^3.7.0 | ||
sdk: ^3.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik we don't need to update the SDK constraint for this, you only need 3.6.0
. It is better to keep this version lower to increase compatibility.
sdk: ^3.9.0 | |
sdk: ^3.7.0 |
Same for the other packages please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped commit: 4fb3fc8 chore: Bump sdk to ^3.9.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, the workspace won't resolve unless you are on sdk ^3.9.0-163.0.dev, since that is the current lower bound in pkgs/dart_mcp_server/pubspec.yaml.
…ng Flutter SDK a dependency during development
8fb4910
to
ac3e4c5
Compare
Setup Dart 3.6 workspace
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.