Skip to content

Add a user exposed way of tracking performance #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue Jan 9, 2018 · 2 comments
Closed

Add a user exposed way of tracking performance #823

jakemac53 opened this issue Jan 9, 2018 · 2 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug type-performance

Comments

@jakemac53
Copy link
Contributor

jakemac53 commented Jan 9, 2018

With lazy builds especially it is extremely difficult to track performance in a general way. I think we need to expose to the Builder implementors a way of explicitly tracking the things they care about.

I see at least three potential ways this could be exposed:

  • Add a method to BuildStep.
  • Add a top level method similar to log which uses an instance of a tracker hanging off the current zone.
  • Create a new package which exposes a performance tracker as a Resource. It could log performance information in its dispose callback. This would have the benefit of separating the details out of the build package itself.
@jakemac53 jakemac53 added type-enhancement A request for a change that isn't a bug P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jan 9, 2018
@jakemac53 jakemac53 added this to the M1: Future priority milestone Jan 9, 2018
@natebosch
Copy link
Member

This would have the benefit of separating the details out of the build package itself.

I definitely like the idea of being able to opt in to this separately from the rest of Build and not even be exposed to it otherwise.

@jakemac53
Copy link
Contributor Author

This is done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug type-performance
Projects
None yet
Development

No branches or pull requests

3 participants