Skip to content

Request: Synchronous logging interface #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matanlurey opened this issue Jan 26, 2018 · 4 comments
Closed

Request: Synchronous logging interface #914

matanlurey opened this issue Jan 26, 2018 · 4 comments
Labels
type-question A question about expected behavior or functionality

Comments

@matanlurey
Copy link
Contributor

Forked from #759.

I'd like to see a simplified logging interface that better matches user intention, and is synchronous (unlike package:logging), which will make many things more trivial and understandable, especially around testing and failing on severe.

abstract class BuildLogger {
  void info(String message, [...]);
  void warn(String message, [Object exception, StackTrace trace]);
  void error(String message, [...]);
}

Other ideas:

  • Do we need something like .debug or .fine?
  • Should we add performance tracing here too (.trace and .traceAsync?)
@matanlurey matanlurey added the type-question A question about expected behavior or functionality label Jan 26, 2018
@natebosch
Copy link
Member

.trace could tie in with #823

Is there value in designing something that can be used outside of the build ecosystem as well?

@matanlurey
Copy link
Contributor Author

Probably, but personally I'd rather slow our roll of trying to fix everything.

(There isn't much importance for CLI-based logging outside of the Dart team itself)

@jakemac53
Copy link
Contributor

@matanlurey I did update it so that we synchronously capture severe logs (just wrapping the logger). Do you think that is enough or is there still value in this from your perspective?

@matanlurey
Copy link
Contributor Author

Value? Yes. Priority? No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-question A question about expected behavior or functionality
Projects
None yet
Development

No branches or pull requests

3 participants