Initial api #11
Merged
Initial api #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
force-pushed
the
initial-api
branch
from
5263539 to
8c0aadb
Compare
| @@ -0,0 +1,112 @@ | |||
| // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
You can probably ignore this file, no changes currently from the barback version
|
Ok, all comments addressed |
|
LGTM |
This was referenced Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first cut at the initial api, any and all suggestions welcome.
There is also a very rough implementation included (lib/generate/build.dart) but I wouldn't focus on that, it is just enough to get the example up and running.
Also you will probably note there are no tests yet, I will add those once I have general buy-in on the api. There is an example though (e2e_example folder) so you can see how the api comes together from a user perspective.
I am also open to other package names, there seems to be a general consensus that
buildis a bit generic.