Skip to content

Change build_web_compilers to dev version #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Change build_web_compilers to dev version #2753

merged 1 commit into from
Jul 13, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Jul 13, 2020

Since it now depends on a dev SDK we must release it as a dev version.

@grouma grouma requested review from jakemac53 and natebosch July 13, 2020 16:41
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jul 13, 2020
@jakemac53
Copy link
Contributor

Since it now depends on a dev SDK we must release it as a dev version.

Is this a warning or error? If it is a warning we can bypass it. If it is an error we should file an issue to turn it into a warning.

We don't want to be blocked from doing any stable releases until the next stable sdk.

@grouma
Copy link
Member Author

grouma commented Jul 13, 2020

This is an error:

Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version.

Opened https://github.com/dart-lang/pub/issues/2557

@grouma
Copy link
Member Author

grouma commented Jul 13, 2020

Looks like the check is actually server side. We'll move forward with this change and publish a non pre-release version when 2.9.0 lands. This should unblock consuming the package in package:dwds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants