Try out using msgpack for asset graph #2779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #41 See if this makes a meaningful difference for performance.
|
We typically prefer to avoid taking on a dependency on third party packages from our core tools. We need to decide between accepting a dep, building our own msgpack implementation, or maintaining the use of json... |
|
We should also do more investigation into where the slowness is happening here as well - if it is simply the writing of the file to disk we could for instance gzip it. |
|
Closing this, as it is a few years old now. Feel free to reopen in case you still want to land it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #41
See if this makes a meaningful difference for performance.