Skip to content

add basic constructors for PackageGraph/PackageNode #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

jakemac53
Copy link
Contributor

No description provided.

@jakemac53 jakemac53 added this to the v0.1.1 release milestone Feb 5, 2016
@jakemac53 jakemac53 changed the title add basic constructors for PacakgeGraph/PackageNode add basic constructors for PackageGraph/PackageNode Feb 5, 2016
b.dependencies.add(c);
var graph = new PackageGraph.fromRoot(a);
expect(graph.root, a);
expect(graph.allPackages, {'a': a, 'b': b, 'c': c, 'd': d,});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove trailing ,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah the formatter always gets me on these when it smooshes them into one line :(

@sigmundch
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants