-
Notifications
You must be signed in to change notification settings - Fork 215
add some basic build tests to get started, as well as a basic test framework #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+348
−52
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,226 @@ | ||
| // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
| import 'package:test/test.dart'; | ||
|
|
||
| import 'package:build/build.dart'; | ||
|
|
||
| import '../common/common.dart'; | ||
|
|
||
| main() { | ||
| group('build', () { | ||
| group('with root package inputs', () { | ||
| test('one phase, one builder, one-to-one outputs', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder()], [new InputSet('a')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, {'a|web/a.txt': 'a', 'a|lib/b.txt': 'b'}, | ||
| outputs: {'a|web/a.txt.copy': 'a', 'a|lib/b.txt.copy': 'b'}); | ||
| }); | ||
|
|
||
| test('one phase, one builder, one-to-many outputs', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder(numCopies: 2)], [new InputSet('a')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, { | ||
| 'a|web/a.txt': 'a', | ||
| 'a|lib/b.txt': 'b', | ||
| }, outputs: { | ||
| 'a|web/a.txt.copy.0': 'a', | ||
| 'a|web/a.txt.copy.1': 'a', | ||
| 'a|lib/b.txt.copy.0': 'b', | ||
| 'a|lib/b.txt.copy.1': 'b', | ||
| }); | ||
| }); | ||
|
|
||
| test('one phase, multiple builders', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder(), new CopyBuilder(extension: 'clone')], | ||
| [new InputSet('a')]), | ||
| new Phase([new CopyBuilder(numCopies: 2)], [new InputSet('a')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, { | ||
| 'a|web/a.txt': 'a', | ||
| 'a|lib/b.txt': 'b', | ||
| }, outputs: { | ||
| 'a|web/a.txt.copy': 'a', | ||
| 'a|web/a.txt.clone': 'a', | ||
| 'a|lib/b.txt.copy': 'b', | ||
| 'a|lib/b.txt.clone': 'b', | ||
| 'a|web/a.txt.copy.0': 'a', | ||
| 'a|web/a.txt.copy.1': 'a', | ||
| 'a|lib/b.txt.copy.0': 'b', | ||
| 'a|lib/b.txt.copy.1': 'b', | ||
| }); | ||
| }, skip: 'Failing, outputs from phases in same group are available'); | ||
|
|
||
| test('multiple phases, multiple builders', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder()], [new InputSet('a')]), | ||
| ], | ||
| [ | ||
| new Phase([ | ||
| new CopyBuilder(extension: 'clone') | ||
| ], [ | ||
| new InputSet('a', filePatterns: ['**/*.txt']) | ||
| ]), | ||
| ], | ||
| [ | ||
| new Phase([ | ||
| new CopyBuilder(numCopies: 2) | ||
| ], [ | ||
| new InputSet('a', filePatterns: ['web/*.txt.clone']) | ||
| ]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, { | ||
| 'a|web/a.txt': 'a', | ||
| 'a|lib/b.txt': 'b', | ||
| }, outputs: { | ||
| 'a|web/a.txt.copy': 'a', | ||
| 'a|web/a.txt.clone': 'a', | ||
| 'a|lib/b.txt.copy': 'b', | ||
| 'a|lib/b.txt.clone': 'b', | ||
| 'a|web/a.txt.clone.copy.0': 'a', | ||
| 'a|web/a.txt.clone.copy.1': 'a', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| group('inputs from other packages', () { | ||
| test('only gets inputs from lib, can output to root package', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase( | ||
| [new CopyBuilder(outputPackage: 'a')], [new InputSet('b')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, {'b|web/b.txt': 'b', 'b|lib/b.txt': 'b'}, | ||
| outputs: {'a|lib/b.txt.copy': 'b'}); | ||
| }); | ||
|
|
||
| test('can\'t output files in non-root packages', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder()], [new InputSet('b')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, {'b|lib/b.txt': 'b'}, | ||
| outputs: {}, status: BuildStatus.Failure); | ||
| }, | ||
| skip: 'Failing, InMemoryAssetWriter doesn\'t throw. Need to handle ' | ||
| 'this in BuildStep instead of AssetWriter.'); | ||
| }); | ||
|
|
||
| test('multiple phases, inputs from multiple packages', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder()], [new InputSet('a')]), | ||
| new Phase([ | ||
| new CopyBuilder(extension: 'clone', outputPackage: 'a') | ||
| ], [ | ||
| new InputSet('b', filePatterns: ['**/*.txt']), | ||
| ]), | ||
| ], | ||
| [ | ||
| new Phase([ | ||
| new CopyBuilder(numCopies: 2, outputPackage: 'a') | ||
| ], [ | ||
| new InputSet('a', filePatterns: ['lib/*.txt.*']), | ||
| new InputSet('b', filePatterns: ['**/*.dart']), | ||
| ]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, { | ||
| 'a|web/1.txt': '1', | ||
| 'a|lib/2.txt': '2', | ||
| 'b|lib/3.txt': '3', | ||
| 'b|lib/b.dart': 'main() {}', | ||
| }, outputs: { | ||
| 'a|web/1.txt.copy': '1', | ||
| 'a|lib/2.txt.copy': '2', | ||
| 'a|lib/3.txt.clone': '3', | ||
| 'a|lib/2.txt.copy.copy.0': '2', | ||
| 'a|lib/2.txt.copy.copy.1': '2', | ||
| 'a|lib/3.txt.clone.copy.0': '3', | ||
| 'a|lib/3.txt.clone.copy.1': '3', | ||
| 'a|lib/b.dart.copy.0': 'main() {}', | ||
| 'a|lib/b.dart.copy.1': 'main() {}', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| group('errors', () { | ||
| test('when overwriting files', () async { | ||
| var phases = [ | ||
| [ | ||
| new Phase([new CopyBuilder()], [new InputSet('a')]), | ||
| ] | ||
| ]; | ||
| await testPhases(phases, {'a|lib/a.txt': 'a', 'a|lib/a.txt.copy': 'a'}, | ||
| status: BuildStatus.Failure, | ||
| exceptionMatcher: invalidOutputException); | ||
| }, | ||
| skip: 'InMemoryAssetWriter doesn\'t check this, should be handled at ' | ||
| 'the BuildStep level.'); | ||
| }); | ||
|
|
||
| test('outputs from previous full builds shouldn\'t be inputs to later ones', | ||
| () {}, | ||
| skip: 'Unimplemented'); | ||
| } | ||
|
|
||
| testPhases(List<List<Phase>> phases, Map<String, String> inputs, | ||
| {Map<String, String> outputs, | ||
| PackageGraph packageGraph, | ||
| BuildStatus status: BuildStatus.Success, | ||
| exceptionMatcher}) async { | ||
| final writer = new InMemoryAssetWriter(); | ||
| final actualAssets = writer.assets; | ||
| final reader = new InMemoryAssetReader(actualAssets); | ||
| inputs.forEach((serializedId, contents) { | ||
| writer.writeAsString(makeAsset(serializedId, contents)); | ||
| }); | ||
|
|
||
| if (packageGraph == null) { | ||
| var rootPackage = new PackageNode('a', null, null, null); | ||
| packageGraph = new PackageGraph.fromRoot(rootPackage); | ||
| } | ||
|
|
||
| var result = await build(phases, | ||
| reader: reader, writer: writer, packageGraph: packageGraph); | ||
| expect(result.status, status); | ||
| if (exceptionMatcher != null) { | ||
| expect(result.exception, exceptionMatcher); | ||
| } | ||
|
|
||
| if (outputs != null) { | ||
| var remainingOutputIds = | ||
| new List.from(result.outputs.map((asset) => asset.id)); | ||
| outputs.forEach((serializedId, contents) { | ||
| var asset = makeAsset(serializedId, contents); | ||
| remainingOutputIds.remove(asset.id); | ||
|
|
||
| /// Check that the writer wrote the assets | ||
| expect(actualAssets, contains(asset.id)); | ||
| expect(actualAssets[asset.id], asset.stringContents); | ||
|
|
||
| /// Check that the assets exist in [result.outputs]. | ||
| var actual = result.outputs | ||
| .firstWhere((output) => output.id == asset.id, orElse: () => null); | ||
| expect(actual, isNotNull, | ||
| reason: 'Expected to find ${asset.id} in ${result.outputs}.'); | ||
| expect(asset, equalsAsset(actual)); | ||
| }); | ||
|
|
||
| expect(remainingOutputIds, isEmpty, | ||
| reason: 'Unexpected outputs found `$remainingOutputIds`.'); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird indentation from dartfmt? :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya :/
I can file a bug in a bit