Skip to content

Add benchmark tool. #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Jan 30, 2025

For #3800

Example output

built_value      
libraries clean/ms no changes/ms incremental/ms
1 20352 2872 4018
100 23670 3012 6433
250 29385 3183 12855
500 43299 4126 33312
750 70317 6590 66698
1000 110399 9757 113382
freezed      
libraries clean/ms no changes/ms incremental/ms
1 21249 2933 5208
100 22365 3007 6527
250 24815 3156 10736
500 37032 3498 21278
750 50651 4921 41368
1000 73173 6513 65284
json_serializable      
libraries clean/ms no changes/ms incremental/ms
1 21573 2840 4278
100 23040 2974 6327
250 28098 3285 12578
500 42940 4288 35061
750 69483 6561 67670
1000 115941 9178 119308
mockito      
libraries clean/ms no changes/ms incremental/ms
1 20752 2964 3998
100 21182 3055 5841
250 23911 3055 7754
500 29450 3335 13729
750 34840 3759 22373
1000 46205 5003 30148

Copy link

github-actions bot commented Jan 30, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan force-pushed the add-benchmarks branch 4 times, most recently from 5df7b98 to 1c8d410 Compare January 30, 2025 14:46
@davidmorgan davidmorgan marked this pull request as ready for review January 30, 2025 15:01
@davidmorgan davidmorgan requested a review from jakemac53 January 30, 2025 15:02
@davidmorgan
Copy link
Contributor Author

Also @jensjoha who is going to start looking at build_runner things from the CFE side.

@davidmorgan davidmorgan mentioned this pull request Jan 30, 2025
return;
}

// Incremental build after a change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, this kind of incremental build is probably a lot slower than a "watch" mode incremental build, because this is going to do a lot of startup work (reading asset graph, scanning and hashing all files to check for changes, etc).

Ideally, we would be able to exclude that (or separate it out).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup yup, we probably want finer-grained benchmarks as we go.

For now this seems to give a clear enough signal :)

Thanks.

@davidmorgan davidmorgan merged commit afd2645 into dart-lang:master Jan 31, 2025
74 of 75 checks passed
@davidmorgan davidmorgan deleted the add-benchmarks branch January 31, 2025 09:36
@davidmorgan davidmorgan mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants