make AssetGraph serializable #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AssetGraphVersionError(this.versionSeen, this.currentVersion); | ||
|
|
||
| @override | ||
| String toString() => 'AssetGraphVersionError: saw version $versionSeen but ' |
There was a problem hiding this comment.
Is it possible to be more concrete? What component of the system saw (read? deserialized?) the incorrect version?
There was a problem hiding this comment.
Actually I need to rename this to Exception not Error. In practice I plan on catching this Exception and just starting the build from scratch in this case, so the user should never see the message.
|
LGTM |
jakemac53
force-pushed
the
cach-asset-graph
branch
from
cf42ae8 to
7f0ce90
Compare
kevmoo
added
type-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.