Add explicit types to for-in loops #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around for dart-lang/sdk#31884 in the dev.17.0 version of the SDK
jakemac53
approved these changes
Jan 12, 2018
| @@ -144,7 +144,7 @@ void checkBuild(BuildResult result, | |||
|
|
|||
| final unhiddenOutputs = <String, dynamic>{}; | |||
| final unhiddenAssets = new Set<AssetId>(); | |||
| for (final id in outputs?.keys ?? const []) { | |||
| for (final String id in outputs?.keys ?? const []) { | |||
There was a problem hiding this comment.
nit: we should try to get more consistent about final vs not in for loops... :)
not a blocker anything as its a preexisting issue
There was a problem hiding this comment.
Yeah I know that the larger community pushed back against "final everywhere" but I find that I occasionally slip back into that habit...
There was a problem hiding this comment.
ya honestly I don't care, I can see it either way, but I do care that it is consistent :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around for dart-lang/sdk#31884 in the
dev.17.0 version of the SDK