Skip to content

co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_dynamic_t22 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scheglov opened this issue Jun 30, 2021 · 2 comments
Closed

co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_dynamic_t22 #1109

scheglov opened this issue Jun 30, 2021 · 2 comments
Assignees
@iarkh

Comments

@scheglov
Copy link

The comment dart-lang/sdk#44163 (comment) makes me think that the test is not valid, and the reported compile-time error is correct.
@scheglov
Copy link
Author

Similarly dart-lang/sdk#44161, and following tests:

co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_static_t16
co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_static_t17
co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_static_t18
co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_static_t19
co19/LanguageFeatures/nnbd/Least-greatest-closure/typedef/typedef_static_t22

@scheglov
Copy link
Author

Probably also co19/LanguageFeatures/nnbd/weak/Least-greatest-closure/typedef/typedef_dynamic_t22.

@iarkh iarkh self-assigned this Jul 1, 2021
@iarkh iarkh closed this as completed in 32ff0cc Jul 14, 2021
iarkh added a commit that referenced this issue Jul 20, 2021
@iarkh
Issue #1109: Libraries_and_Scripts test updated, new tests added.
cd90715
iarkh added a commit that referenced this issue Nov 2, 2021
@iarkh
More fix for #1109: Test LibraryFeatures/nnbd/Least-greatest-closure/…
9579a74 
…typedef/typedef_dynamic_t22 removed according to the issue evaluation, static exception is thrown.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 11, 2021
@athomas
[co19] Roll co19 to 39c5bbc03bf5c5c0a3f9341abe811871eababfaf
684b63d 
2021-11-11 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-10 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to LibTest/io tests, minor change for LibTest/core/RangeError/CheckNotNegative_A01_t02
2021-11-10 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-09 [email protected] More fix for dart-lang/co19#1094: co19_2 LibTest/collection/DoubleLinkedQueue tests corrected according to the Issue 27920 evaluation and current behavior.
2021-11-09 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-08 [email protected] dart-lang/co19#1231. Super parameters type inference tests added
2021-11-02 [email protected] Fix tests on Mac OS X. (dart-lang/co19#1233)
2021-11-03 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Missing Issue tags added to LibTest/async tests.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: LanguageFeatures/nnbd tests updated according to the recent dart behaviour, missing Issdue tags added.
2021-11-02 [email protected] More fix for dart-lang/co19#1109: Test LibraryFeatures/nnbd/Least-greatest-closure/typedef/typedef_dynamic_t22 removed according to the issue evaluation, static exception is thrown.
2021-11-02 [email protected] More fix for dart-lang/co19#1094: Test expectation updated for LanguageFeatures/Set-literals/constant_set_literals_A01_t01 test.
2021-11-02 [email protected] Fixes dart-lang/co19#1232. Expect FileStat.type to return underlying object for non-Windows OS's
2021-11-01 [email protected] dart-lang/co19#1231. More super parameters tests added
2021-10-29 [email protected] dart-lang/co19#1231. The first bunch of super parameters tests added
2021-10-28 [email protected] Fixes dart-lang/co19#1228. More named arguments anywhere constructors tests added
2021-10-27 [email protected] dart-lang/co19#1228. More named arguments anywhere tests added
2021-10-26 [email protected] dart-lang/co19#1228. Named arguments anywhere tests added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Ie70e28bc259aa9bacc3512866e92a2768e456271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220003
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iarkh iarkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @iarkh