-
Notifications
You must be signed in to change notification settings - Fork 28
co19/LanguageFeatures/Constructor-tear-offs/ambiguities_A06_t03.dart issue #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@eernstg, I'm curious - how do we know when this fix has rolled into the latest co19 used in dart-lang/sdk? |
@devoncarew roll is in progress now. https://dart-review.googlesource.com/c/sdk/+/211581 |
great - thanks for the update |
In terms of a recipe to find out, you can get the co19 commit hash in the DEPS: And then look at the fix and see if it landed before or after the commit. |
As we try and burn down the list of failures for a specific language feature, it may be worth having an easier way - for people casually looking at a co19 issue - to see if it's been rolled into the sdk. Perhaps when it's fixed in co19 the issue is closed (as today), and when that fix rolls into the sdk we add an update to the issue saying it's been rolled in? I'm not sure how much overhead that would add to the co19 roll process. |
In said test, line 56,
x(42)
is used in a situation wherex
has static typeType
, and this causes a compile-time error which is not expected by the test. Presumably line 56 can just be deleted.The text was updated successfully, but these errors were encountered: