co19/LanguageFeatures/Constructor-tear-offs/ambiguities_A06_t03.dart issue

[eernstg]

In said test, line 56, x(42) is used in a situation where x has static type Type, and this causes a compile-time error which is not expected by the test. Presumably line 56 can just be deleted.

[devoncarew]

@eernstg, I'm curious - how do we know when this fix has rolled into the latest co19 used in dart-lang/sdk?

[sgrekhov]

@devoncarew roll is in progress now. https://dart-review.googlesource.com/c/sdk/+/211581

[devoncarew]

great - thanks for the update

[eernstg]

Thanks, @sgrekhov! In general, @athomas and @whesse would have the most detailed and up-to-date knowledge about co19 rolls.

[athomas]

In terms of a recipe to find out, you can get the co19 commit hash in the DEPS:
https://github.com/dart-lang/sdk/blob/master/DEPS#L47

And then look at the fix and see if it landed before or after the commit.

[devoncarew]

As we try and burn down the list of failures for a specific language feature, it may be worth having an easier way - for people casually looking at a co19 issue - to see if it's been rolled into the sdk. Perhaps when it's fixed in co19 the issue is closed (as today), and when that fix rolls into the sdk we add an update to the issue saying it's been rolled in? I'm not sure how much overhead that would add to the co19 roll process.