Skip to content

co19/LanguageFeatures/Constructor-tear-offs/ambiguities_A06_t03.dart issue #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eernstg opened this issue Aug 12, 2021 · 6 comments
Closed

Comments

@eernstg
Copy link
Member

eernstg commented Aug 12, 2021

In said test, line 56, x(42) is used in a situation where x has static type Type, and this causes a compile-time error which is not expected by the test. Presumably line 56 can just be deleted.

@devoncarew
Copy link
Member

@eernstg, I'm curious - how do we know when this fix has rolled into the latest co19 used in dart-lang/sdk?

@sgrekhov
Copy link
Contributor

@devoncarew roll is in progress now. https://dart-review.googlesource.com/c/sdk/+/211581

@devoncarew
Copy link
Member

great - thanks for the update

@eernstg
Copy link
Member Author

eernstg commented Aug 30, 2021

Thanks, @sgrekhov! In general, @athomas and @whesse would have the most detailed and up-to-date knowledge about co19 rolls.

@athomas
Copy link
Member

athomas commented Aug 30, 2021

In terms of a recipe to find out, you can get the co19 commit hash in the DEPS:
https://github.com/dart-lang/sdk/blob/master/DEPS#L47

And then look at the fix and see if it landed before or after the commit.

@devoncarew
Copy link
Member

As we try and burn down the list of failures for a specific language feature, it may be worth having an easier way - for people casually looking at a co19 issue - to see if it's been rolled into the sdk. Perhaps when it's fixed in co19 the issue is closed (as today), and when that fix rolls into the sdk we add an update to the issue saying it's been rolled in? I'm not sure how much overhead that would add to the co19 roll process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants