Skip to content

io/Directory/renameSync_A02_t01.dart should not expect an existing directory to be replaced #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brianquinlan opened this issue Nov 17, 2021 · 2 comments
Closed

io/Directory/renameSync_A02_t01.dart should not expect an existing directory to be replaced #1236

brianquinlan opened this issue Nov 17, 2021 · 2 comments
Assignees
@sgrekhov

Comments

@brianquinlan
Copy link
Contributor

I'd change the test to put a file in the target directory and verify that an error is generated.
@sgrekhov sgrekhov self-assigned this Nov 18, 2021
@sgrekhov
Copy link
Contributor

@brianquinlan I updated rename() and renameSync() tests according to the new behavior. But I didn't find information if Fuchsia is POSIX system or not. Do you have any information about it?

co19/LibTest/io/Directory/renameSync_A02_t04.dart

Lines 32 to 35 in baa3a87

bool isPosix = Platform.isAndroid ||
Platform.isIOS ||
Platform.isMacOS ||
Platform.isLinux;

@brianquinlan
Copy link
Contributor Author

I suspect that Fushia has the POSIX behavior but I'm not sure.

sgrekhov pushed a commit that referenced this issue Nov 19, 2021
#1236. Fuchsia added to the list of POSIX systems
28322d7
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 23, 2021
@athomas
[co19] Roll co19 to 4ef349830b971c22d8ddb2970c4ba9002806fd85
429fd8b 
2021-11-23 [email protected] dart-lang/co19#1231. Super parameters tests fixed and new ones added
2021-11-22 [email protected] Fixes dart-lang/co19#1237. More tests for Array and Pointer with wrong types
2021-11-19 [email protected] dart-lang/co19#1237. Added tests for Array wrong types
2021-11-19 [email protected] dart-lang/co19#1236. Fuchsia added to the list of POSIX systems
2021-11-18 [email protected] Fixes dart-lang/co19#1236. Update rename() and renameSync() tests to follow changed behaviour
2021-11-17 [email protected] dart-lang/co19#1231. More super parameters tests added
2021-11-16 [email protected] dart-lang/co19#1231. Minor code style changes
2021-11-16 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-15 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-12 [email protected] dart-lang/co19#1231. More Super parameters tests added
2021-11-12 [email protected] dart-lang/co19#1231. Experimental flag added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I13275efae3ccbb84a6ba9690a8168d8e50a6227b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220963
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @brianquinlan