Skip to content

Failures on [co19] Roll co19 to 310e789d81336ba2b6141788f200e643aa8f0ef7 #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
athomas opened this issue Feb 11, 2022 · 2 comments
Closed

Failures on [co19] Roll co19 to 310e789d81336ba2b6141788f200e643aa8f0ef7 #1301

athomas opened this issue Feb 11, 2022 · 2 comments
Assignees
@sgrekhov

Comments

@athomas
Copy link
Member

athomas commented Feb 11, 2022

There are new test failures on [co19] Roll co19 to 310e789d81336ba2b6141788f200e643aa8f0ef7.

The tests

co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t03 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t02 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t03 Crash (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t05 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t06 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t07 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t08 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t13 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t14 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t15 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t16 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t03 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t04 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t05 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t07 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t08 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t09 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t11 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t12 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t03 CompileTimeError (expected Pass)
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t03 RuntimeError (expected Pass)
    and 67 more tests

are failing on configurations

analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-simarm
dartk-strong-linux-release-simarm64
dartk-strong-linux-release-x64
dartk-strong-win-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-simarm
dartk-weak-asserts-linux-release-simarm64
dartk-weak-asserts-linux-release-x64
dartk-weak-asserts-win-release-x64
dartkp-strong-linux-debug-x64
dartkp-strong-linux-release-simarm64
dartkp-strong-linux-release-x64
dartkp-strong-mac-release-simarm64
dartkp-strong-win-release-x64
dartkp-weak-asserts-linux-debug-x64
dartkp-weak-asserts-linux-release-simarm64
dartkp-weak-asserts-linux-release-x64
dartkp-weak-asserts-mac-release-simarm64
dartkp-weak-asserts-win-release-x64
@sgrekhov sgrekhov self-assigned this Feb 11, 2022
@eernstg
Copy link
Member

eernstg commented Feb 11, 2022

I took a look at the non-crashes:

  • co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t01 MissingCompileTimeError (expected Pass):
    CFE issue: Error for existence of values declaration not yet
    implemented.
  • co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t04 MissingCompileTimeError (expected Pass):
    Test issue for analyzer and CFE: The getter/setter signature error is
    reported on line 18 (whole enum), which could be ok (because the
    generated values doesn't have a line number), but worth
    considering.
    Analyzer and CFE issue: The fact that it's an error to have values at all
    is not reported (line 23, 35).
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t04 MissingCompileTimeError (expected Pass):
    Test issue, CFE and analyzer: getter/setter signature error reported on whole enum,
    like previous test.
    CFE & analyzer issue: No error just for having values at all.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t05 MissingCompileTimeError (expected Pass):
    Likely test issue: I do not think it's specified to be an error to
    have the values instance member in these mixins, it is only an
    error when they are used (with M or implements M) in an actual
    enum declaration. Btw. this is a similar kind of conflict as with
    the Never get index; declaration, but the fact that we don't
    report this as an error is less impactful than with index, so I'm
    less worried; so let's just accept that it isn't an error.
    So please report that the CFE and the analyzer differ on this, and
    ask which one is right. ;-)
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t06 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t07 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t08 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t13 MissingCompileTimeError (expected Pass):
    Similar to previous test (this is abstract class rather than
    mixin, but the considerations are relevant for both).
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t14 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t15 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t16 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t01 MissingCompileTimeError (expected Pass):
    CFE issue: Error based on the fact that index has a concrete
    declaration not yet implemented. (We only get the error that
    E2.index is an incorrect override, and perhaps we shouldn't even
    have that when we get the other error, that you can't override it at
    all).
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t03 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t04 MissingCompileTimeError (expected Pass):
    Test issue: Line 58 declares a setter named index= with parameter
    type int, that should not be an error.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t05 MissingCompileTimeError (expected Pass):
    CFE issue: Error at line 61 because of overriding index not yet
    implemented. Line 72 is an error because it is not a correct
    override, so the error may change from "wrong override" to "can't
    override index at all".
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t07 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t08 MissingCompileTimeError (expected Pass):
    Test issue: The declaration named index= on line 61 should not be
    expected to raise an error.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t09 MissingCompileTimeError (expected Pass):
    CFE issue: Error on concrete index in M1 not yet implemented.
    Error on line 65 may change from "wrong override" to "can't override
    index at all".
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t11 MissingCompileTimeError (expected Pass):
    Similar to previous test.
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t12 MissingCompileTimeError (expected Pass):
    Test issue: The declaration named index= on line 61 should not be
    expected to raise an error.

sgrekhov pushed a commit that referenced this issue Feb 14, 2022
#1301. Roll failures fixed, issue numbers added
a38d7c5
@sgrekhov
Copy link
Contributor

@eernstg thank you! You helped much again!

  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t05 MissingCompileTimeError (expected Pass):
    Likely test issue: I do not think it's specified to be an error to
    have the values instance member in these mixins, it is only an
    error when they are used (with M or implements M) in an actual
    enum declaration. Btw. this is a similar kind of conflict as with
    the Never get index; declaration, but the fact that we don't
    report this as an error is less impactful than with index, so I'm
    less worried; so let's just accept that it isn't an error.
    So please report that the CFE and the analyzer differ on this, and
    ask which one is right. ;-)

Please see dart-lang/sdk#48388
From my point of view the current specification wording forbids even declaration of such mixins and classes

Failures are triaged

analyzer...cfe...  
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t04 Fixed, dart-lang/sdk#48387
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t04 Fixed, dart-lang/sdk#48387
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t04 Fixed
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t08 Fixed, dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t12 Fixed
cfe...  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t02 dart-lang/sdk#48389
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t03 dart-lang/sdk#48389
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t02 dart-lang/sdk#48389
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t03 dart-lang/sdk#48389
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t01 dart-lang/sdk#48387
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t05 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t06 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t07 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t08 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t13 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t14 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t15 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t16 dart-lang/sdk#48388
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t01 dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t03 dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t05 dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t07 dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t09 dart-lang/sdk#48353
co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t11 dart-lang/sdk#48353
dart2js...dartdevk...  
new test -> CompileTimeError (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t03 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t04 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t03 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t04 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A02_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A02_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A03_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t05 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t06 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t07 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t12 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t13 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t14 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A05_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A05_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t03 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t01 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t02 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t03 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t04 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t05 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t06 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t07 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t08 FFI is not supported on web
co19/LanguageFeatures/FinalizationRegistry/no_ffi/WeakReference/expando_key_t04 FFI is not supported on web, moved to ffi folder
co19/LanguageFeatures/FinalizationRegistry/no_ffi/WeakReference/expando_key_t05 FFI is not supported on web, moved to ffi folder
new test -> RuntimeError (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/attach_A04_t11 dart-lang/sdk#48390
dartk...dartkp...  
new test -> RuntimeError (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t02 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t03 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t04 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t02 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t03 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A01_t04 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A02_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A02_t02 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A03_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A05_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A05_t02 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t01 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t02 UnimplementedError: Finalizer
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A06_t03 UnimplementedError: Finalizer
dartk...dartkp...  
new test -> RuntimeError (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t05 Fixed
dartk...dartkp...  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t01 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t02 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t03 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t04 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t05 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t06 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t07 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t08 Simarm is not supported yet
dartk...dartkp...  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t05 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t06 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t07 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t12 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t13 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A04_t14 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/no_ffi/WeakReference/expando_key_t04 Simarm is not supported yet
co19/LanguageFeatures/FinalizationRegistry/no_ffi/WeakReference/expando_key_t05 Simarm is not supported yet
dartkp...  
new test -> RuntimeError (expected Pass)  
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t01 dart-lang/sdk#48391
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t02 dart-lang/sdk#48391
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t03 dart-lang/sdk#48391
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t04 dart-lang/sdk#48391
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t07 dart-lang/sdk#48391
co19/LanguageFeatures/FinalizationRegistry/ffi/WeakReference/weak_reference_target_t08 dart-lang/sdk#48391

@athomas athomas mentioned this issue Feb 14, 2022
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 14, 2022
@athomas
[co19] Roll co19 to a38d7c5685e64499cfbdbfe6548fbd5b63b57f15
e05620f 
2022-02-14 [email protected] dart-lang/co19#1301. Roll failures fixed, issue numbers added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Iaf2c52b135242470e01fa602e8ccb324ef29f957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232840
Reviewed-by: William Hesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @athomas