LanguageFeatures/Records/interaction_with_legacy_A04_t01

[scheglov]

I think we need SharedOptions=--enable-experiment=records in the main test file, so that it is provided for the analyzer run, and then @dart = 2.18 will downgrade the main file, but allow it in the imported library.

[sgrekhov]

@scheglov at first I did exactly in the same way. SharedOptions=--enable-experiment=records were in both legacy and non legacy files. But in this case the following error occurs in CFE

/===================================================================================================================\
| co19/LanguageFeatures/Records/interaction_with_legacy_A04_t01 is new and failed (CompileTimeError, expected Pass) |
\===================================================================================================================/

--- Command "fasta" (took 78ms):
(cd /b/s/w/ir/ ; DART_CONFIGURATION=ReleaseX64 ./out/ReleaseX64/dart ./pkg/front_end/tool/_fasta/compile.dart --verify --skip-platform-verification -o ./out/ReleaseX64/generated_compilations/cfe-strong-linux/tests_co19_src_LanguageFeatures_Records_interaction_with_legacy_A04_t01/out.dill --platform ./out/ReleaseX64/vm_platform_strong.dill -Dtest_runner.configuration=cfe-strong-linux --enable-experiment=records --nnbd-strong --packages=./.dart_tool/package_config.json ./tests/co19/src/LanguageFeatures/Records/interaction_with_legacy_A04_t01.dart )

exit code:
1

stdout:
tests/co19/src/LanguageFeatures/Records/interaction_with_legacy_A04_t01.dart:46:3: Error: The 'records' language feature is disabled for this library.
Try removing the `@dart=` annotation or setting the language version to 2.19 or higher.
  Rec _rec = rec;
  ^^^
tests/co19/src/LanguageFeatures/Records/interaction_with_legacy_A04_t01.dart:34:1: Context: This is the annotation that opts out this library from the 'records' language feature.
// @dart = 2.18
^^^^^^^^^^^^^^^

--- Re-run this test:
python3 tools/test.py -n cfe-strong-linux co19/LanguageFeatures/Records/interaction_with_legacy_A04_t01

That's why I removed experimental flags from the legacy libraries in 0c2b4c6.

Why do you think that we need these flags back?

[scheglov]

It looks that the testing framework gets it correct with SharedOptions=--enable-experiment=records in the main test file, and passes --enable-experiment=records to the _fasta/compile.dart invocation.

The fact that we get errors might be a sign of an issue in CFE, specifically the one that we testing here.