Skip to content

Add more tests for super-bounded types #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgrekhov opened this issue Nov 20, 2023 · 0 comments
Closed

Add more tests for super-bounded types #2386

sgrekhov opened this issue Nov 20, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

We have no tests tor the following statement

It is a compile-time error if a parameterized type T is super-bounded when
it is used in any of the following ways:
• T is an immediate subterm of a new expression (17.13.1) or a constant
object expression (17.13.2).
• T is an immediate subterm of a redirecting factory constructor signature
(10.7.2).
• T is an immediate subterm of an extends clause of a class (10.9), or it
occurs as an element in the type list of an implements clause (10.10), or
a with clause (10).

We also have no any test checking that class C<T extends T> {} is an error
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 20, 2023
@sgrekhov sgrekhov self-assigned this Nov 20, 2023
@sgrekhov sgrekhov changed the title Add more tests for super-bounded Add more tests for super-bounded types Nov 21, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 28, 2023
@sgrekhov
dart-lang#2386. Rename well-bounded tests. Update descriptions
b79288d
eernstg pushed a commit that referenced this issue Dec 11, 2023
@sgrekhov
#2386. Rename well-bounded tests. Update descriptions (#2405)
21a5fc1 
Rename well-bounded tests. Update descriptions.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 19, 2023
@sgrekhov
[co19] Roll co19 to b80c9a4cb6fb22b5c8a7395d532c8e461fe33ab9
8f6be08 
2023-12-19 [email protected] Fixes dart-lang/co19#2441. Fix roll failures (dart-lang/co19#2443)
2023-12-18 [email protected] Fixes dart-lang/co19#2435. Fix roll failures (dart-lang/co19#2437)
2023-12-18 [email protected] dart-lang/co19#2420. Add extension types exhaustiveness tests. Variables (dart-lang/co19#2431)
2023-12-15 [email protected] Fixes dart-lang/co19#2430. Update expected errors positions for CFE (dart-lang/co19#2433)
2023-12-15 [email protected] Fixes dart-lang/co19#2432. Remove excessive expected error for CFE (dart-lang/co19#2434)
2023-12-14 [email protected] dart-lang/co19#2420. Add extension types exhaustiveness tests. Maps (dart-lang/co19#2426)
2023-12-14 [email protected] dart-lang/co19#2420. Add extension types exhaustiveness tests. Lists (dart-lang/co19#2424)
2023-12-14 [email protected] dart-lang/co19#2139. Fix wrong failure of Language/Functions/element_type_A02_t06 (dart-lang/co19#2429)
2023-12-13 [email protected] dart-lang/co19#2350. Add more factory constructors tests (dart-lang/co19#2427)
2023-12-13 [email protected] Fixes dart-lang/co19#2415. Update `StreamController.broadcast()` test according to the changed documentation (dart-lang/co19#2425)
2023-12-13 [email protected] dart-lang/co19#2350. Add/update factory constructor tests. Part 4 (dart-lang/co19#2367)
2023-12-12 [email protected] dart-lang/co19#2420. Add extension types exhaustiveness tests. Enums, trivial cases (dart-lang/co19#2423)
2023-12-11 [email protected] dart-lang/co19#2420. Add extension types exhaustiveness tests. Enums (dart-lang/co19#2422)
2023-12-11 [email protected] dart-lang/co19#2386. Rename well-bounded tests. Update descriptions (dart-lang/co19#2405)
2023-12-08 [email protected] dart-lang/co19#2415. Change expectations for Stream.asyncMap() according to the current behavior (dart-lang/co19#2421)

Change-Id: I777eba4f1615c8477a5d2044f295696dfc210b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342582
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 22, 2024
@sgrekhov
dart-lang#2386. Update super-bounded types tests
ae83335
eernstg pushed a commit that referenced this issue Oct 24, 2024
@sgrekhov
#2386. Update super-bounded types tests (#2942)
5582f30 
Update super-bounded types tests
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 25, 2024
@sgrekhov
[co19] Roll co19 to 5582f300f30244ffd6e363761315d400cc37a023
0d93251 
2024-10-24 [email protected] dart-lang/co19#2386. Update super-bounded types tests (dart-lang/co19#2942)
2024-10-23 [email protected] dart-lang/co19#1400. Add extension types tests for bottom types (dart-lang/co19#2944)
2024-10-18 [email protected] dart-lang/co19#2933. Add MultiStreamController tests. Part 3. (dart-lang/co19#2940)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Id9774ab53b5451962efb1d3c3790725620fd322c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391940
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 25, 2024
@sgrekhov
Fixes dart-lang#2386. Add more super-bounded types tests
f74218a
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 1, 2024
@sgrekhov
[co19] Roll co19 to abef8c3392aeb04a59e94a467d9b08f16401852f
ff3d7a1 
2024-10-29 [email protected] Fixes dart-lang/co19#2954. Don't expect null-aware warnings in CFE (dart-lang/co19#2955)
2024-10-28 [email protected] Fixes dart-lang/co19#2947. Expect AUGMENTATION_OF_DIFFERENT_DECLARATION_KIND in augmenting_types_A02_t14_lib.dart (dart-lang/co19#2952)
2024-10-25 [email protected] Fixes dart-lang/co19#2933. Add one more Stream.multi test (dart-lang/co19#2948)
2024-10-25 [email protected] Fixes dart-lang/co19#2950. Fix run-time errors in null-aware elements tests (dart-lang/co19#2951)
2024-10-25 [email protected] Fixes dart-lang/co19#2386. Add more super-bounded types tests (dart-lang/co19#2949)
2024-10-25 [email protected] Fixes dart-lang/co19#2945. Fix invalid_null_aware_operator in null-aware elements tests (dart-lang/co19#2946)
2024-10-25 [email protected] dart-lang/co19#2933. Add MultiStreamController tests. Part 4. (dart-lang/co19#2941)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I77f4faaa3ad785c9c43bf47807fcf9b355edaa5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392906
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov