Fixes #2123. Update Superclasses tests. #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended `@description` slightly to explain the purpose of 'superclass_lib.dart' more explicitly.
eernstg
approved these changes
Jul 12, 2023
| /// T. | ||
| /// | ||
| /// @description Checks that it is a compile-time error if a deferred type is | ||
| /// used as a superclass |
There was a problem hiding this comment.
This might be helpful for a reader who encounters just this library:
Suggested change
| /// used as a superclass | |
| /// used as a superclass. This library declares the class and will be used in a deferred import. |
Is it correct? Otherwise something similar would be even more useful. ;-)
There was a problem hiding this comment.
(I just did this, so we can land the PR now.)
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 14, 2023
2023-07-14 [email protected] Fixes dart-lang/co19#2132. Fix roll failures, add issue numbers (dart-lang/co19#2134) 2023-07-13 [email protected] Fixes dart-lang/co19#2130. Fix roll failures, add issues numbers (dart-lang/co19#2131) 2023-07-13 [email protected] Fixes dart-lang/co19#2125. Add more external functions tests (dart-lang/co19#2128) 2023-07-13 [email protected] Fixes dart-lang/co19#2087. Reorder covariance tests to make maintenance easier (dart-lang/co19#2129) 2023-07-12 [email protected] dart-lang/co19#2087. Add tests for parameters covariant-by-declaration (dart-lang/co19#2121) 2023-07-12 [email protected] Fixes dart-lang/co19#2117. Update assertions, add tests for external members (dart-lang/co19#2126) 2023-07-12 [email protected] Fixes dart-lang/co19#2123. Update Superclasses tests. (dart-lang/co19#2124) 2023-07-11 [email protected] dart-lang/co19#2117. Update accessible_instance_member_t* tests (dart-lang/co19#2122) 2023-07-10 [email protected] Fixes dart-lang/co19#2099. Add subtyping tests for function type with required named arguments (dart-lang/co19#2100) 2023-07-10 [email protected] dart-lang/co19#2112. Add missing tests for mixins. Part 2 (dart-lang/co19#2118) 2023-07-07 [email protected] dart-lang/co19#2119. Minor wording changes (dart-lang/co19#2120) Change-Id: I310f2e0a660ac55a242bb9b2ed9a2f1917555d0f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313562 Reviewed-by: Alexander Thomas <[email protected]>
osa1
pushed a commit
to osa1/sdk
that referenced
this pull request
Jul 17, 2023
2023-07-14 [email protected] Fixes dart-lang/co19#2132. Fix roll failures, add issue numbers (dart-lang/co19#2134) 2023-07-13 [email protected] Fixes dart-lang/co19#2130. Fix roll failures, add issues numbers (dart-lang/co19#2131) 2023-07-13 [email protected] Fixes dart-lang/co19#2125. Add more external functions tests (dart-lang/co19#2128) 2023-07-13 [email protected] Fixes dart-lang/co19#2087. Reorder covariance tests to make maintenance easier (dart-lang/co19#2129) 2023-07-12 [email protected] dart-lang/co19#2087. Add tests for parameters covariant-by-declaration (dart-lang/co19#2121) 2023-07-12 [email protected] Fixes dart-lang/co19#2117. Update assertions, add tests for external members (dart-lang/co19#2126) 2023-07-12 [email protected] Fixes dart-lang/co19#2123. Update Superclasses tests. (dart-lang/co19#2124) 2023-07-11 [email protected] dart-lang/co19#2117. Update accessible_instance_member_t* tests (dart-lang/co19#2122) 2023-07-10 [email protected] Fixes dart-lang/co19#2099. Add subtyping tests for function type with required named arguments (dart-lang/co19#2100) 2023-07-10 [email protected] dart-lang/co19#2112. Add missing tests for mixins. Part 2 (dart-lang/co19#2118) 2023-07-07 [email protected] dart-lang/co19#2119. Minor wording changes (dart-lang/co19#2120) Change-Id: I310f2e0a660ac55a242bb9b2ed9a2f1917555d0f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313562 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.