Skip to content

#2242. Change CRLF line endings to LF #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

sgrekhov
Copy link
Contributor

Github doesn't show me removed \r. @eernstg if you saw them, please confirm

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though it isn't easy to see at all! ;-)

@eernstg eernstg merged commit 3f43f65 into dart-lang:master Aug 30, 2023
@eernstg
Copy link
Member

eernstg commented Aug 30, 2023

if you saw them, please confirm

Looks right, I get just a couple of UTF-8 and string literal related tests with any other line terminator than \n.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 4, 2023
2023-09-04 [email protected] dart-lang/co19#2145. Fix roll failure (LateInitializationError) (dart-lang/co19#2257)
2023-09-04 [email protected] dart-lang/co19#2145. Add more local variable declaration tests (dart-lang/co19#2254)
2023-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (dart-lang/co19#2256)
2023-09-01 [email protected] dart-lang/co19#2213. Fix stack trace comparison (dart-lang/co19#2255)
2023-09-01 [email protected] dart-lang/co19#2145. Update variables tests according to the current spec. Part 2 (dart-lang/co19#2240)
2023-08-31 [email protected] dart-lang/co19#2242. Add LFCR line ending test (dart-lang/co19#2251)
2023-08-31 [email protected] dart-lang/co19#2145. Rename Local Variable declaration tests. Delete duplicates (dart-lang/co19#2252)
2023-08-30 [email protected] dart-lang/co19#2242. Add line endings tests (dart-lang/co19#2250)
2023-08-30 [email protected] Fixes dart-lang/co19#2245. Fix expectations in static_analysis_extension_types_A24_t02.dart (dart-lang/co19#2248)
2023-08-30 [email protected] dart-lang/co19#2242. Change CRLF line endings to LF (dart-lang/co19#2249)
2023-08-30 [email protected] Fixes dart-lang/co19#2244. Fix typo in dynamic_semantics_member_invocation_A01_t02.dart (dart-lang/co19#2247)
2023-08-30 [email protected] Fixes dart-lang/co19#2243. Remove duplicated constructors (dart-lang/co19#2246)
2023-08-29 [email protected] dart-lang/co19#2145. Update assertions and descriptions in the current Local variable declaration tests (dart-lang/co19#2241)
2023-08-25 [email protected] Fixes dart-lang/co19#2235. Add missing operator tests (dart-lang/co19#2239)
2023-08-25 [email protected] dart-lang/co19#2119. Code format and description update in operator tests (dart-lang/co19#2238)

Change-Id: I5aeac05c1aa4cbaa0762ce4f23c1ee916d1006a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324040
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-2242-1 branch November 14, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants