#2242. Change CRLF line endings to LF #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Aug 30, 2023
Looks right, I get just a couple of UTF-8 and string literal related tests with any other line terminator than |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 4, 2023
2023-09-04 [email protected] dart-lang/co19#2145. Fix roll failure (LateInitializationError) (dart-lang/co19#2257) 2023-09-04 [email protected] dart-lang/co19#2145. Add more local variable declaration tests (dart-lang/co19#2254) 2023-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (dart-lang/co19#2256) 2023-09-01 [email protected] dart-lang/co19#2213. Fix stack trace comparison (dart-lang/co19#2255) 2023-09-01 [email protected] dart-lang/co19#2145. Update variables tests according to the current spec. Part 2 (dart-lang/co19#2240) 2023-08-31 [email protected] dart-lang/co19#2242. Add LFCR line ending test (dart-lang/co19#2251) 2023-08-31 [email protected] dart-lang/co19#2145. Rename Local Variable declaration tests. Delete duplicates (dart-lang/co19#2252) 2023-08-30 [email protected] dart-lang/co19#2242. Add line endings tests (dart-lang/co19#2250) 2023-08-30 [email protected] Fixes dart-lang/co19#2245. Fix expectations in static_analysis_extension_types_A24_t02.dart (dart-lang/co19#2248) 2023-08-30 [email protected] dart-lang/co19#2242. Change CRLF line endings to LF (dart-lang/co19#2249) 2023-08-30 [email protected] Fixes dart-lang/co19#2244. Fix typo in dynamic_semantics_member_invocation_A01_t02.dart (dart-lang/co19#2247) 2023-08-30 [email protected] Fixes dart-lang/co19#2243. Remove duplicated constructors (dart-lang/co19#2246) 2023-08-29 [email protected] dart-lang/co19#2145. Update assertions and descriptions in the current Local variable declaration tests (dart-lang/co19#2241) 2023-08-25 [email protected] Fixes dart-lang/co19#2235. Add missing operator tests (dart-lang/co19#2239) 2023-08-25 [email protected] dart-lang/co19#2119. Code format and description update in operator tests (dart-lang/co19#2238) Change-Id: I5aeac05c1aa4cbaa0762ce4f23c1ee916d1006a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324040 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github doesn't show me removed
\r. @eernstg if you saw them, please confirm