#2420. Add object-pattern exhaustiveness tests #2454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 29, 2023
There was a problem hiding this comment.
This one is again blocked (on dart-lang/language#3534 and dart-lang/language#3524, no less).
It should again be possible to split it into two PRs, one which is OK today, and another one which is blocked.
eernstg
added
the
status-blocked
sgrekhov
commented
Jan 4, 2024
sgrekhov
removed
the
status-blocked
eernstg
approved these changes
Jan 4, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 5, 2024
2024-01-05 [email protected] Fixes dart-lang/co19#2465. Fix roll failures (dart-lang/co19#2466) 2024-01-04 [email protected] dart-lang/co19#2420. Add object-pattern exhaustiveness tests (dart-lang/co19#2454) 2024-01-04 [email protected] dart-lang/co19#2420. Add relational pattern exhaustiveness tests (dart-lang/co19#2463) 2024-01-03 [email protected] dart-lang/co19#2420. Add missed experimental flags (dart-lang/co19#2462) 2024-01-03 [email protected] Fixes dart-lang/co19#2436. Add test for external constructors with initializers (dart-lang/co19#2461) 2024-01-02 [email protected] dart-lang/co19#2420. Add more dynamic semantics extension type tests (dart-lang/co19#2459) 2024-01-02 [email protected] Fixes dart-lang/co19#2436. Add tests for external and redirecting constructors with initializing formals (dart-lang/co19#2460) 2023-12-29 [email protected] dart-lang/co19#1400. Add object pattern tests for extension types (dart-lang/co19#2456) 2023-12-29 [email protected] dart-lang/co19#1400. Add type inference tests for extension types (dart-lang/co19#2455) 2023-12-29 [email protected] dart-lang/co19#2420. Add switch statement check to the existing exhaustiveness tests (dart-lang/co19#2452) Change-Id: Iee0668f14a35bb3c47aa67b35b1e5c6d8abe8021 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345040 Reviewed-by: William Hesse <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.