Fixes #2491. Add test that an extension type cannot implement type Never
#2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
LGTM.
One could say that this is just one more test where we determine that an error is reported in the case where the representation type isn't a subtype of an implemented non-extension type. Anyway, it's ok to have this special case even if it is somewhat redundant with other tests where the relation between representation type and implemented types is being tested.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 19, 2024
2024-01-18 [email protected] dart-lang/co19#2477. Add test checking that an operator can be redeclared (dart-lang/co19#2495) 2024-01-18 [email protected] Fixes dart-lang/co19#2479. Delete outdated test co19/LibTest/ffi/sizeOf/sizeOf_A01_t02 (dart-lang/co19#2483) 2024-01-17 [email protected] dart-lang/co19#2485. Add constants `as T` tests (dart-lang/co19#2489) 2024-01-17 [email protected] dart-lang/co19#2477. Add more constant evaluation tests (dart-lang/co19#2484) 2024-01-17 [email protected] Fixes dart-lang/co19#2487. Add tests for type cast and type `void` (dart-lang/co19#2492) 2024-01-17 [email protected] Fixes dart-lang/co19#2486. `Pointer.elementAt` replaced by `+` operator (dart-lang/co19#2488) 2024-01-17 [email protected] Fixes dart-lang/co19#2491. Add test that an extension type cannot implement type `Never` (dart-lang/co19#2493) 2024-01-12 [email protected] dart-lang/co19#2477. Add match operators constants evaluation tests (dart-lang/co19#2482) Change-Id: I1dee628d4685b0b24296aaabfcf4abcb659fa765 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347240 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that the statement in the assertion doesn't contain any mentions of type
Neverbut I didn't found a better one in the spec. May be the typeNeverwas just forgotten there?