-
Notifications
You must be signed in to change notification settings - Fork 29
#3180. Add tests for createJSInteropWrapper()
function
#3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take another iteration on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd maybe add a test where it's okay to have an exported class that has a member with an invalid type but it never exports it e.g.
class C {
final D d; // not exported
@JSExport()
int get boo => d.bar();
C(this.d);
}
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
2025-08-29 [email protected] dart-lang/co19#3180. Add tests for `ObjectToJSBoxedDartObject` (dart-lang/co19#3291) 2025-08-29 [email protected] Fixes dart-lang/co19#3292. Ignore some analyzer warnings, add issue numbers (dart-lang/co19#3295) 2025-08-29 [email protected] dart-lang/co19#3180. Fix delete_A01_t06.dart to work in both strict/non-strict modes (dart-lang/co19#3290) 2025-08-28 [email protected] dart-lang/co19#3292. Update assertions for `reachability_switch_*` tests (dart-lang/co19#3293) 2025-08-27 [email protected] dart-lang/co19#3180. Add tests for `JSObjectUnsafeUtilExtension` (dart-lang/co19#3289) 2025-08-26 [email protected] dart-lang/co19#3180. Add JSFunctionUnsafeUtilExtension tests (dart-lang/co19#3285) 2025-08-26 [email protected] dart-lang/co19#3180. Add `callMethod` and `callMethodVarArgs` tests (dart-lang/co19#3288) 2025-08-25 [email protected] dart-lang/co19#3180. Add tests for `createJSInteropWrapper()` function (dart-lang/co19#3283) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I8188f94fcf0ffbfbb4c117abb80676f9675fb06e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447721 Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Ivan Inozemtsev <[email protected]>
Existing tests for
JSExport
also testscreateJSInteropWrapper()
function. So there are only few new tests here.