-
Notifications
You must be signed in to change notification settings - Fork 23
Can Level be renamed to LogLevel? #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is tough because there isn't a good migration story. I'd be hesitant to do it even with a breaking release bump because the churn would be pretty painful. I do think we should hold on to it, if we do get the ability to add type aliases such that we can have an incremental migration we should consider it. |
We do have type aliases now. cc @kevmoo @jakemac53 for opinions on whether it's worth the churn to deprecate |
IMO no we shouldn't bother, we just end up polluting the namespace further. Individuals can also set up their own alias easily, if they choose to do so. |
I TOTALLY understand the annoyance here.
I TOTALLY don't think it's worth it....
…On Wed, Aug 31, 2022 at 3:43 PM Jacob MacDonald ***@***.***> wrote:
IMO no we shouldn't bother, we just end up polluting the namespace further.
Individuals can also set up their own alias easily, if they choose to do
so.
—
Reply to this email directly, view it on GitHub
<#445>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCSHRDUZPRLJIYODI3TV367V5ANCNFSM4HKYDV2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, I agree. |
The naming of types seems inconsistent. There's
Logger
,LogRecord
,LoggerHandler
... and then there'sLevel
.I either need to have a somewhat meaningless
Level
name polluting my global namespace or I need to do:import 'package:logging/logging.dart' as log;
but then I end up with
log.Logger
,log.LogRecord
,log.LoggerHandler
, which looks a bit silly.I don't know if there's any reasonable way to do anything about this currently, although once dart-lang/sdk#2626 is fixed, I suppose
Level
could be a (deprecated?)typedef
toLogLevel
.The text was updated successfully, but these errors were encountered: