Skip to content

add strict_top_level_inference to the core lint set #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @devoncarew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds the strict_top_level_inference lint to the core lint set. This change involves modifying the CHANGELOG.md, core.yaml, and rules.md files to include the new lint rule. The PR also closes issue #836 in the dart-lang/core repository.

Highlights

  • Lint Rule Addition: The strict_top_level_inference lint has been added to the core lint set.
  • Configuration Update: The core.yaml file has been updated to include the new lint rule.
  • Documentation Update: The rules.md file has been updated to document the new lint rule.
  • Changelog Update: The CHANGELOG.md file has been updated to reflect the addition of the new lint rule.

Changelog

  • pkgs/lints/CHANGELOG.md
  • pkgs/lints/lib/core.yaml
    • Added strict_top_level_inference to the list of lint rules in the core lint set at line 36.
  • pkgs/lints/rules.md
    • Added a row to the table documenting the strict_top_level_inference lint rule at line 35.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A new lint arrives with grace,
strict_top_level_inference finds its place.
In core.yaml, it takes its stand,
Improving code throughout the land.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds the strict_top_level_inference lint to the core lint set. The changes are minimal and seem correct. I've added a few comments to improve the changelog entry and ensure consistency in the markdown table.

Summary of Findings

  • Changelog entry formatting: The changelog entry could be improved by providing a more descriptive message about the added lint rule.
  • Markdown table alignment: The alignment of the new entry in rules.md should be checked to ensure it matches the existing table format.

Assessment

The pull request adds strict_top_level_inference to the core lint set, which is a good step towards enforcing stricter type annotations. The changes are straightforward and seem correct. I've provided some minor feedback to improve clarity and consistency. Please ensure that others review and approve this code before merging.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
lints None 5.1.1 6.0.0-wip 5.1.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@devoncarew devoncarew merged commit 9f43210 into main Feb 26, 2025
14 checks passed
@devoncarew devoncarew deleted the add_strict_top_level_inference branch February 26, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

consider adding strict_top_level_inference
3 participants