Skip to content

Allow using URI strings in "part of" declarations #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidmorgan opened this issue Apr 11, 2017 · 3 comments
Closed

Allow using URI strings in "part of" declarations #615

davidmorgan opened this issue Apr 11, 2017 · 3 comments

Comments

@davidmorgan
Copy link

According to the 1.23 CHANGELOG this is now supported in the language, but dartfmt doesn't seem to be happy with it.

dartfmt 0.2.16 on the command line removes a "part of" URI from the file if I use one.

Formatting via the dart_style library seems to refuse to format files using a URI "part of" -- seen in this pull request for source_gen trying to change the generated code: dart-lang/source_gen#138

@davidmorgan
Copy link
Author

Do we just need to wait for an analyzer release to fix this? Thanks.

@munificent
Copy link
Member

No, there's work to be done in dartfmt too.

It was a mistake to put this feature in the 1.23 CHANGELOG and has since been removed: dart-lang/sdk@9add06f. The feature hasn't officially shipped yet (in part because dartfmt doesn't support it yet).

@davidmorgan
Copy link
Author

Got it. Thanks!

munificent added a commit that referenced this issue May 9, 2017
munificent added a commit that referenced this issue May 10, 2017
* Support URIs in part-of directives.

Fix #615.

* Add tests for and tweak how function types are formatted.

* Remove duplicate test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants