Skip to content

dartfmt: Support generalized void #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eernstg opened this issue Sep 1, 2017 · 5 comments
Closed

dartfmt: Support generalized void #649

eernstg opened this issue Sep 1, 2017 · 5 comments

Comments

@eernstg
Copy link
Member

eernstg commented Sep 1, 2017

This is the dartfmt specific issue for dart-lang/sdk#30176, which has the details.

@zoechi
Copy link

zoechi commented Feb 14, 2018

seems to be a blocker now

@munificent
Copy link
Member

I just tried this with both the version of dart_style in the Dart SDK (which means using the bleeding edge analyzer) and the external dart_style package using analyzer 0.31.1 and this was formatted fine:

main() {
  List<void> nothings;
}

I still need to add tests but as far as I can tell, it's working. Is there something I'm missing?

@leafpetersen
Copy link
Member

Re-opening: the following fails to parse and format:

typedef G2 = void Function([void]);

@leafpetersen leafpetersen reopened this Jul 25, 2018
@munificent
Copy link
Member

munificent commented Aug 6, 2018

Blocked on dart-lang/sdk#30177.

@natebosch
Copy link
Member

This is working on the given example and the linked SDK issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants