Skip to content

Support non-function type aliases. #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

Support non-function type aliases. #1013

merged 2 commits into from
Mar 31, 2021
+53 −4

Conversation

munificent
Copy link
Member

Fix #993.

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
munificent
munificent commented Mar 30, 2021
View reviewed changes
lib/src/source_visitor.dart
@@ -1819,7 +1819,7 @@ class SourceVisitor extends ThrowingAstVisitor {

space();

visit(node.functionType);
visit(node.type);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only real change needed to get this working. :)

stereotype441
stereotype441 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukepighetti
Copy link

lukepighetti commented Mar 31, 2021 •
edited
Loading

I have been using this PR for a few hours on a project targeting 2.13.0-0 and it's working beautifully, FWIW.

@munificent munificent merged commit 939ede3 into master Mar 31, 2021
@munificent munificent deleted the type-aliases branch March 31, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereotype441 stereotype441

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement non-function type alias support in dart format
3 participants
@munificent @lukepighetti @stereotype441