Enable support for inline class syntax #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I usually wait until there is public analyzer AST support for new syntax before I add formatting support. Is it OK if we wait until the analyzer folks have published a version before we land this? |
|
Yep, that's why it is draft :) The CL has landed and I am going to ask analyzer to be published next. |
|
And we are ready to go. |
|
Analyzer started using methods from 2.19 so we need to bump the action to use 2.19. |
|
Now everything cycles green. |
|
friendly ping @munificent |
|
Fixed conflicts in CHANGELOG.md. Still waiting for review. |
munificent
approved these changes
Mar 6, 2023
auto-merge was automatically disabled
March 6, 2023 20:05
Merge commits are not allowed on this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty draft of the support. Currently we can't access
inlineTokenbecause public AST API does not expose it.We need this CL to land first and then publish analyzer. Once that happens I will bump analyzer version in pubspec and convert this draft PR into a proper PR.
/cc @munificent
Fixes #1129