Skip to content

Overriding getter with member variable causes docs to get lost #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tvolkert opened this issue Oct 4, 2018 · 2 comments
Closed

Overriding getter with member variable causes docs to get lost #1779

tvolkert opened this issue Oct 4, 2018 · 2 comments
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@tvolkert
Copy link

tvolkert commented Oct 4, 2018

Consider the following:

library foo;

/// Base class docs
class Base {
  /// Great, thorough documentation
  bool get foo => true;
}

/// Subclass docs
class Sub extends Base {
  @override
  final bool foo = false;
}

When I look up the dartdocs for Sub.foo, I expect to see "Great, thorough documentation". Yet there are no docs for Sub.foo.

@tvolkert
Copy link
Author

tvolkert commented Oct 4, 2018

/cc @jcollins-g

@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on customer-flutter Issues originating from important to Flutter labels Oct 4, 2018
jcollins-g added a commit that referenced this issue Oct 4, 2018
@jcollins-g
Copy link
Contributor

This is another case that was fixed in as part of cleanups for #1765 and will be fixed when this lands. #1781 adds a specific test for this case.

jcollins-g added a commit that referenced this issue Oct 8, 2018
…1781)

* Implement new-style mixin support

* Regenerate package documentation, dropping stable

* Fix problem where we created Fields without accessors

* Use published analyzer in override

* Disable try_publish and make grind more tolerant of preexisting overrides to make travis green

* Test for #1779

* Review comments

* dartfmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants