Adapt sdk-test dependency overrides for non-nullable analyzer #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we instead just expand the normal dependency constraints? |
No. I actually started down that road earlier -- it turns out that several of the intermediate packages dartdoc depends on have constraints of their own. For now, it seems best to submit this, then work on fixing those other packages so we can expand our constraints successfully. |
srawlins
reviewed
Feb 4, 2021
| @@ -598,6 +605,7 @@ Future<void> startTestPackageDocsServer() async { | |||
| log('launching dhttpd on port 8002 for SDK'); | |||
| var launcher = SubprocessLauncher('serve-test-package-docs'); | |||
| await launcher.runStreamed(sdkBin('pub'), [ | |||
| 'global', | |||
srawlins
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with #2500 until the new analyzer is published, at least.