Introduce basic generic type alias support for dartdoc #2558
+271
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Mar 8, 2021
| T4 = generalizedTypedefs.typedefs.firstWhere((a) => a.name == 'T4'); | ||
| T5 = generalizedTypedefs.typedefs.firstWhere((a) => a.name == 'T5'); | ||
| T6 = generalizedTypedefs.typedefs.firstWhere((a) => a.name == 'T6'); | ||
| T7 = generalizedTypedefs.typedefs.firstWhere((a) => a.name == 'T7'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces basic generic type alias support. We no longer crash when encountering them in most (all?) cases, and do something reasonable in the documentation (though arguably it could be prettier).
There are a few additional tests and tweaks I would like to add before declaring #2499 fixed. In particular, when aliasing special types like void this currently does not properly refer to the type alias when it is referenced later (instead displaying
void). I also have an idea to programmatically generate dartdoc documentation from SDK language tests for a visual inspection to identify problems like this that I want to implement.Nevertheless, this is pretty close and if we absolutely had to we could likely ship with this and patch up the rest later.