Add a template for sitemap generation #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keertip
added a commit
that referenced
this pull request
Dec 11, 2014
Add a template for sitemap generation
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| {{#links}} | ||
| <url> | ||
| <loc>{{name}}</loc> |
There was a problem hiding this comment.
loc needs to be a fully qualified URL, beginning with http or https
There was a problem hiding this comment.
Yes, have added a TODO in the dart code to fix that. Was not sure what the url would be.
There was a problem hiding this comment.
Maybe pass it in from command line?
There was a problem hiding this comment.
So generate sitemap only when the option is passed in?
There was a problem hiding this comment.
That's probably the easiest way to handle this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sethladd
Also added tests and turned on tests on Travis.