Remove cross-export warning #3523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few examples of exporting (and even documenting) one package's elements from another package:
package:flutter/widgets.dart
exportspackage:characters/characters.dart
package:test/expect.dart
exportspackage:matcher/expect.dart
package:test/fake.dart
exportspackage:test_api/fake.dart
Theoretically these packages were getting warnings about cross-package exports, but the logic that determined if the warning should be shown was wrong: The logic was "If none of the re-exports are from the same package" (or, "if all of the re-exports are cross-package"). But that would even include the library where an element is declared, so I don't think the warning ever fired. Given that it wasn't working, and we don't need the warning (devs get use out of these cross-package exports), we should remove it.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.