Simplify web code http requests and use static interop #3613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused how changing three calls to use a single method from a new package ends up with a ≈75KB bundle size increase :/ I'm going to keep this in draft a bit to investigate. The simplification is likely not worth it, and everyone using |
parlough
force-pushed
the
misc/simplify-webui-http-code
branch
from
7be80b1 to
a845d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3610 for easier review on the road towards modern static JS interop.
package:httpalready uses static interop (throughpackage:web), so we shouldn't try to repeat the work from there.