Skip to content

Fix sidebars via correct web API for anchor href values #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

srawlins
Copy link
Member

Fixes #3933


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

@srawlins srawlins requested a review from athomas November 20, 2024 18:06
@srawlins srawlins merged commit c7f1160 into dart-lang:main Nov 20, 2024
7 checks passed
@srawlins srawlins deleted the fix-sidebars branch November 20, 2024 18:18
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 21, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/6af0821..1de8372):
  1de83727  2024-11-20  Lasse R.H. Nielsen  Implement full Unicode 16.0.0 extended grapheme breaking. (dart-lang/core#719)

dartdoc (https://github.com/dart-lang/dartdoc/compare/f8a55e4..c7f1160):
  c7f11603  2024-11-20  Sam Rawlins  Fix sidebars via correct web API for anchor href values (dart-lang/dartdoc#3934)

http (https://github.com/dart-lang/http/compare/e37093f..79470d0):
  79470d0  2024-11-19  Brian Quinlan  Include names in argument lists (dart-lang/http#1408)

shelf (https://github.com/dart-lang/shelf/compare/0bb44cb..a2708cd):
  a2708cd  2024-11-21  Devon Carew  shorten the issue badges (dart-lang/shelf#456)

Change-Id: Iee20d2300d1bf0e43a57b352b73235ae24fa5e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396960
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links on dev after the change to remove index.html pages
2 participants