http headers Content-Type problems

[DartBot]

Originally opened as dart-lang/sdk#17405

This issue was originally filed by [email protected]

---

A Content-Type header is ignored when sending http.post.

If I call http.post with a header "Content-Type", the server doesn't get the value specified if there is also a body. Instead, it always gets "text/plain; charset=utf-8".

If I change the header key to "content-type", everything works as expected.

There are several issues here.

1. I would expect the header key to be used case-insensitive.
2. Requests set body has as side-effect that the _contentType is set.

This side-effect is documented, however it explicitly mentions "Content-Type". And so does Requests ContentType get \_contentType.

I've attached two source files to demonstrate the problem.

---

Attachments:
httpheadersserver.dart (288 Bytes)
httpheadersclient.dart (243 Bytes)
pubspec.yaml (91 Bytes)

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl

---

Added Area-IO, Triaged labels.

[DartBot]

This comment was originally written by [email protected]

---

I think the problem is in base_request.dart:

 BaseRequest(this.method, this.url)
    : headers = <String, String>{};

This map is not case-insensitive, it should be. A few lines higher, I've found the following comment:

  // TODO(nweiz): make this a HttpHeaders object
  /// The headers for this request.
  final Map<String, String> headers;

I tried to figure out if I could make a patch, but I encountered two problems:

• I don't understand how I would be able to use the LinkedHashMap external factory that accepts alternative equality and hash functions for keys
• Currently I can't build all dart projects on my machine

[DartBot]

<img src="https://avatars.githubusercontent.com/u/22043?v=3" align="left" width="48" height="48"hspace="10"> Comment by skabet

---

I'm re-assigning, as this is the http package, and not dart:io directly.

Thanks for filing this!

---

Removed Area-IO label.
Added Area-pkg, Pkg-Http labels.

[DartBot]

This comment was originally written by [email protected]

---

Created a patch: https://codereview.chromium.org/198423002

[DartBot]

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

---

Added Duplicate label.
Marked as being merged into #13.