Skip to content

Stop depending on stack_trace #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Stop depending on stack_trace #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/browser_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'dart:html';
import 'dart:typed_data';

import 'package:async/async.dart';
import 'package:stack_trace/stack_trace.dart';

import 'src/base_client.dart';
import 'src/exception.dart';
Expand Down Expand Up @@ -64,7 +63,7 @@ class BrowserClient extends BaseClient {
reader.onError.first.then((error) {
completer.completeError(
new ClientException(error.toString(), request.url),
new Chain.current());
StackTrace.current);
});

reader.readAsArrayBuffer(blob);
Expand All @@ -75,7 +74,7 @@ class BrowserClient extends BaseClient {
// specific information about the error itself.
completer.completeError(
new ClientException("XMLHttpRequest error.", request.url),
new Chain.current());
StackTrace.current);
});

xhr.send(bytes);
Expand Down
1 change: 0 additions & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
collection: "^1.5.0"
http_parser: ">=0.0.1 <4.0.0"
path: ">=0.9.0 <2.0.0"
stack_trace: ">=0.9.1 <2.0.0"
dev_dependencies:
test: "^0.12.18"
# Override dependency on package_resolver to enable test
Expand Down