Skip to content

Conversation

brianquinlan
Copy link
Collaborator


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:cupertino_http Issues related to package:cupertino_http package:cronet_http labels Jul 1, 2024
@brianquinlan brianquinlan requested a review from natebosch July 1, 2024 21:16
@brianquinlan brianquinlan merged commit 719dc5f into dart-lang:master Jul 2, 2024
Anikate-De added a commit to Anikate-De/http that referenced this pull request Jul 7, 2024
commit 4178b67
Author: Brian Quinlan <[email protected]>
Date:   Wed Jul 3 17:16:38 2024 -0700

    Clarify when Client.close must be called (dart-lang#1255)

commit 719dc5f
Author: Brian Quinlan <[email protected]>
Date:   Tue Jul 2 11:18:29 2024 -0700

    Upgrade to http_image_provider: 0.0.3 (dart-lang#1253)

commit 75b1efb
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jul 2 10:46:54 2024 -0700

    Bump the github-actions group across 1 directory with 4 updates (dart-lang#1251)

    Bumps the github-actions group with 4 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [subosito/flutter-action](https://github.com/subosito/flutter-action), [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) and [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart).

    Updates `actions/checkout` from 4.1.1 to 4.1.7
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@b4ffde6...692973e)

    Updates `subosito/flutter-action` from 2.12.0 to 2.16.0
    - [Release notes](https://github.com/subosito/flutter-action/releases)
    - [Commits](subosito/flutter-action@2783a3f...44ac965)

    Updates `reactivecircus/android-emulator-runner` from 2.30.1 to 2.31.0
    - [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases)
    - [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md)
    - [Commits](ReactiveCircus/android-emulator-runner@6b0df4b...77986be)

    Updates `dart-lang/setup-dart` from 1.6.4 to 1.6.5
    - [Release notes](https://github.com/dart-lang/setup-dart/releases)
    - [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md)
    - [Commits](dart-lang/setup-dart@f0ead98...0a8a0fc)

    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: subosito/flutter-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    - dependency-name: reactivecircus/android-emulator-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    - dependency-name: dart-lang/setup-dart
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit cdfb94c
Author: Brian Quinlan <[email protected]>
Date:   Mon Jul 1 14:16:10 2024 -0700

    Add an section explaining the benefits of using `package:ok_http`. (dart-lang#1252)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 8, 2024
…em, file, glob, http, http_multi_server, http_parser, json_rpc_2, logging, mockito, package_config, source_maps, source_span, sync_http, test, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/6a5a2e6..1a24d61):
  1a24d61  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/args#278)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c76d7c8..02f190b):
  02f190b  2024-07-01  Kevin Moore  blast_repo fixes (dart-archive/bazel_worker#94)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f6ef33d..a06785c):
  a06785c  2024-07-01  Kevin Moore  blast_repo fixes (dart-archive/benchmark_harness#108)

collection (https://github.com/dart-lang/collection/compare/9354f38..0c1f829):
  0c1f829  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/collection#354)

ecosystem (https://github.com/dart-lang/ecosystem/compare/54ca01a..4171189):
  4171189  2024-07-02  Jacob MacDonald  support nested packages in firehose (dart-lang/ecosystem#277)
  459041b  2024-07-01  dependabot[bot]  Bump the github-actions group with 4 updates (dart-lang/ecosystem#275)

file (https://github.com/google/file.dart/compare/07cacae..855831c):
  855831c  2024-07-01  dependabot[bot]  Bump actions/checkout from 4.1.6 to 4.1.7 (dart-archive/file.dart#242)
  da79121  2024-07-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.4 to 1.6.5 (dart-archive/file.dart#241)

glob (https://github.com/dart-lang/glob/compare/6d3ba5e..8b05be8):
  8b05be8  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/glob#96)

http (https://github.com/dart-lang/http/compare/8d89385..4178b67):
  4178b67  2024-07-03  Brian Quinlan  Clarify when Client.close must be called (dart-lang/http#1255)
  719dc5f  2024-07-02  Brian Quinlan  Upgrade to http_image_provider: 0.0.3 (dart-lang/http#1253)
  75b1efb  2024-07-02  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/http#1251)
  cdfb94c  2024-07-01  Brian Quinlan  Add an section explaining the benefits of using `package:ok_http`. (dart-lang/http#1252)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/25941e2..8348be1):
  8348be1  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/http_multi_server#71)

http_parser (https://github.com/dart-lang/http_parser/compare/9bf7bd9..ce528cf):
  ce528cf  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/http_parser#101)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/616937f..b4810dc):
  b4810dc  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/json_rpc_2#117)

logging (https://github.com/dart-lang/logging/compare/6c3fb37..8752902):
  8752902  2024-07-01  Kevin Moore  blast_repo fixes (dart-archive/logging#170)

mockito (https://github.com/dart-lang/mockito/compare/a7fdf71..eb4d1da):
  eb4d1da  2024-07-03  James Lin  Update with review feedback from srawlins
  db19e8c  2024-06-05  James Lin  Provide better documentation for `provideDummy`/`provideDummyBuilder`
  330976e  2024-07-01  dependabot[bot]  Bump the github-actions group across 1 directory with 2 updates (dart-lang/mockito#761)

package_config (https://github.com/dart-lang/package_config/compare/903a0e5..f0b7256):
  f0b7256  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/package_config#156)

source_maps (https://github.com/dart-lang/source_maps/compare/caa79c2..5f82c61):
  5f82c61  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/source_maps#95)

source_span (https://github.com/dart-lang/source_span/compare/89520f3..f81cd4a):
  f81cd4a  2024-07-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-archive/source_span#115)

sync_http (https://github.com/dart-lang/sync_http/compare/7622bdd..ab8377e):
  ab8377e  2024-07-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.2 to 1.6.5 (google/sync_http.dart#48)

test (https://github.com/dart-lang/test/compare/3256c23..14f9b3e):
  14f9b3ec  2024-07-08  Jacob MacDonald  use pub workspaces (dart-lang/test#2249)
  c14ce93a  2024-07-03  Nate Bosch  Prepare to publish (dart-lang/test#2250)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/57a28da..d605cce):
  d605cce  2024-07-04  Kavisi  Fix fold literal encoding with trailing line break (dart-archive/yaml_edit#91)

Change-Id: I70ee32b3fa1912457b7b08affb3446523ef3b0d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374860
Reviewed-by: Brian Quinlan <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cronet_http package:cupertino_http Issues related to package:cupertino_http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants